Use a more powerful query to match videos in img tags

Also, always add a link to download videos since video playback is
tricky. Also, it solves the issue with email client not supporting
videos.

Signed-off-by: Rémy Coutable <remy@rymai.me>

1 files changed, 16 insertions, 10 deletions

diff --git a/spec/lib/banzai/filter/video_link_filter_spec.rb b/spec/lib/banzai/filter/video_link_filter_spec.rb
index 8ccfb9c0fca..bdf76c458b0 100644
--- a/spec/lib/banzai/filter/video_link_filter_spec.rb
+++ b/spec/lib/banzai/filter/video_link_filter_spec.rb
@@ -9,28 +9,34 @@ describe Banzai::Filter::VideoLinkFilter, lib: true do
     described_class.call(doc, contexts)
   end
 
-  def image(path)
+  def link_to_image(path)
     %(<img src="#{path}" />)
   end
 
   let(:project) { create(:project) }
 
   context 'when the element src has a video extension' do
-    it 'replaces the image tag with a video tag' do
-      doc = filter(image("/path/video.mov"))
-      element = doc.children.first
-      expect(element.name).to eq( "video" )
-      expect(element['src']).to eq( "/path/video.mov" )
+    UploaderHelper::VIDEO_EXT.each do |ext|
+      it "replaces the image tag 'path/video.#{ext}' with a video tag" do
+        element = filter(link_to_image("/path/video.#{ext}")).children.first
+
+        expect(element.name).to eq 'video'
+        expect(element['src']).to eq "/path/video.#{ext}"
+
+        fallback_link = element.children.first
+        expect(fallback_link.name).to eq 'a'
+        expect(fallback_link['href']).to eq "/path/video.#{ext}"
+        expect(fallback_link['target']).to eq '_blank'
+      end
     end
   end
 
   context 'when the element src is an image' do
     it 'leaves the document unchanged' do
-      doc = filter(image("/path/my_image.jpg"))
-      element = doc.children.first
-      expect(element.name).to eq( "img" )
+      element = filter(link_to_image("/path/my_image.jpg")).children.first
+
+      expect(element.name).to eq 'img'
     end
   end
 
-
 end