Merge branch 'cache-user-keys-count' into 'master'

Cache the number of user SSH keys

See merge request gitlab-org/gitlab-ce!15401

2 files changed, 146 insertions, 0 deletions

diff --git a/spec/services/base_count_service_spec.rb b/spec/services/base_count_service_spec.rb
new file mode 100644
index 00000000000..5ec8ed0976d
--- /dev/null
+++ b/spec/services/base_count_service_spec.rb
@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+describe BaseCountService, :use_clean_rails_memory_store_caching do
+  let(:service) { described_class.new }
+
+  describe '#relation_for_count' do
+    it 'raises NotImplementedError' do
+      expect { service.relation_for_count }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe '#count' do
+    it 'returns the number of values' do
+      expect(service)
+        .to receive(:cache_key)
+        .and_return('foo')
+
+      expect(service)
+        .to receive(:uncached_count)
+        .and_return(5)
+
+      expect(service.count).to eq(5)
+    end
+  end
+
+  describe '#uncached_count' do
+    it 'returns the uncached number of values' do
+      expect(service)
+        .to receive(:relation_for_count)
+        .and_return(double(:relation, count: 5))
+
+      expect(service.uncached_count).to eq(5)
+    end
+  end
+
+  describe '#refresh_cache' do
+    it 'refreshes the cache' do
+      allow(service)
+        .to receive(:cache_key)
+        .and_return('foo')
+
+      allow(service)
+        .to receive(:uncached_count)
+        .and_return(4)
+
+      service.refresh_cache
+
+      expect(Rails.cache.fetch(service.cache_key, raw: service.raw?)).to eq(4)
+    end
+  end
+
+  describe '#delete_cache' do
+    it 'deletes the cache' do
+      allow(service)
+        .to receive(:cache_key)
+        .and_return('foo')
+
+      allow(service)
+        .to receive(:uncached_count)
+        .and_return(4)
+
+      service.refresh_cache
+      service.delete_cache
+
+      expect(Rails.cache.fetch(service.cache_key, raw: service.raw?)).to be_nil
+    end
+  end
+
+  describe '#raw?' do
+    it 'returns false' do
+      expect(service.raw?).to eq(false)
+    end
+  end
+
+  describe '#cache_key' do
+    it 'raises NotImplementedError' do
+      expect { service.cache_key }.to raise_error(NotImplementedError)
+    end
+  end
+end
diff --git a/spec/services/users/keys_count_service_spec.rb b/spec/services/users/keys_count_service_spec.rb
new file mode 100644
index 00000000000..a188cf86772
--- /dev/null
+++ b/spec/services/users/keys_count_service_spec.rb
@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Users::KeysCountService, :use_clean_rails_memory_store_caching do
+  let(:user) { create(:user) }
+  let(:service) { described_class.new(user) }
+
+  describe '#count' do
+    before do
+      create(:personal_key, user: user)
+    end
+
+    it 'returns the number of SSH keys as an Integer' do
+      expect(service.count).to eq(1)
+    end
+
+    it 'caches the number of keys in Redis' do
+      service.delete_cache
+
+      recorder = ActiveRecord::QueryRecorder.new do
+        2.times { service.count }
+      end
+
+      expect(recorder.count).to eq(1)
+    end
+  end
+
+  describe '#refresh_cache' do
+    it 'refreshes the Redis cache' do
+      Rails.cache.write(service.cache_key, 10)
+      service.refresh_cache
+
+      expect(Rails.cache.fetch(service.cache_key, raw: true)).to be_zero
+    end
+  end
+
+  describe '#delete_cache' do
+    it 'removes the cache' do
+      service.count
+      service.delete_cache
+
+      expect(Rails.cache.fetch(service.cache_key, raw: true)).to be_nil
+    end
+  end
+
+  describe '#uncached_count' do
+    it 'returns the number of SSH keys' do
+      expect(service.uncached_count).to be_zero
+    end
+
+    it 'does not cache the number of keys' do
+      recorder = ActiveRecord::QueryRecorder.new do
+        2.times { service.uncached_count }
+      end
+
+      expect(recorder.count).to be > 0
+    end
+  end
+
+  describe '#cache_key' do
+    it 'returns the cache key' do
+      expect(service.cache_key).to eq("users/key-count-service/#{user.id}")
+    end
+  end
+end