summaryrefslogtreecommitdiff
path: root/spec/services/auto_merge
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2019-06-26 18:58:24 +0700
committerShinya Maeda <shinya@gitlab.com>2019-07-04 13:26:39 +0700
commitdf3a0f261360b319d553c7122ac1e7abe6099de0 (patch)
tree957c5456032f69b4677404d407a27ed48f62c9e2 /spec/services/auto_merge
parent19dc1105524e3d25821670706a750043775588fa (diff)
downloadgitlab-ce-df3a0f261360b319d553c7122ac1e7abe6099de0.tar.gz
Fix MWPS system notes shows inconsistent shafix-mwps-shows-inconsistent-sha-ce
Fix the system note service
Diffstat (limited to 'spec/services/auto_merge')
-rw-r--r--spec/services/auto_merge/base_service_spec.rb5
-rw-r--r--spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb5
2 files changed, 9 insertions, 1 deletions
diff --git a/spec/services/auto_merge/base_service_spec.rb b/spec/services/auto_merge/base_service_spec.rb
index cd08e0b6f32..24cb63a0d61 100644
--- a/spec/services/auto_merge/base_service_spec.rb
+++ b/spec/services/auto_merge/base_service_spec.rb
@@ -59,6 +59,11 @@ describe AutoMerge::BaseService do
context 'when strategy is merge when pipeline succeeds' do
let(:service) { AutoMerge::MergeWhenPipelineSucceedsService.new(project, user) }
+ before do
+ pipeline = build(:ci_pipeline)
+ allow(merge_request).to receive(:actual_head_pipeline) { pipeline }
+ end
+
it 'sets the auto merge strategy' do
subject
diff --git a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb
index a20bf8e17e4..5e84ef052ce 100644
--- a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb
+++ b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb
@@ -64,8 +64,11 @@ describe AutoMerge::MergeWhenPipelineSucceedsService do
end
it 'creates a system note' do
+ pipeline = build(:ci_pipeline)
+ allow(merge_request).to receive(:actual_head_pipeline) { pipeline }
+
note = merge_request.notes.last
- expect(note.note).to match %r{enabled an automatic merge when the pipeline for (\w+/\w+@)?\h{8}}
+ expect(note.note).to match "enabled an automatic merge when the pipeline for #{pipeline.sha}"
end
end