diff options
author | Brett Walker <bwalker@gitlab.com> | 2019-01-11 18:31:00 -0600 |
---|---|---|
committer | Brett Walker <bwalker@gitlab.com> | 2019-01-21 15:07:40 -0600 |
commit | 7bc0fbe22f0dd2c96b596b591ef5dbf3eaae8dd3 (patch) | |
tree | e59cc0f740c8511a58d057f16864f9cf661cd8ec /spec/serializers | |
parent | 45a04f93747a128588268395071f00d0af70acd7 (diff) | |
download | gitlab-ce-7bc0fbe22f0dd2c96b596b591ef5dbf3eaae8dd3.tar.gz |
Fix review comments
including refactoring, disabling sourcepos for pipelines that
don't need it, and minimizing spec changes by disabling
sourcepos when not testing for it explicitly.
Diffstat (limited to 'spec/serializers')
-rw-r--r-- | spec/serializers/group_child_entity_spec.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/serializers/group_child_entity_spec.rb b/spec/serializers/group_child_entity_spec.rb index 7f2ddc9546a..d02b4c554b1 100644 --- a/spec/serializers/group_child_entity_spec.rb +++ b/spec/serializers/group_child_entity_spec.rb @@ -10,6 +10,7 @@ describe GroupChildEntity do before do allow(request).to receive(:current_user).and_return(user) + stub_commonmark_sourcepos_disabled end shared_examples 'group child json' do @@ -102,7 +103,7 @@ describe GroupChildEntity do let(:description) { ':smile:' } it 'has the correct markdown_description' do - expect(json[:markdown_description]).to eq('<p data-sourcepos="1:1-1:7" dir="auto"><gl-emoji title="smiling face with open mouth and smiling eyes" data-name="smile" data-unicode-version="6.0">😄</gl-emoji></p>') + expect(json[:markdown_description]).to eq('<p dir="auto"><gl-emoji title="smiling face with open mouth and smiling eyes" data-name="smile" data-unicode-version="6.0">😄</gl-emoji></p>') end end |