Use ResourceLabelEvent for tracking label changes

2 files changed, 72 insertions, 3 deletions

diff --git a/spec/models/label_note_spec.rb b/spec/models/label_note_spec.rb
new file mode 100644
index 00000000000..f69874d94aa
--- /dev/null
+++ b/spec/models/label_note_spec.rb
@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe LabelNote do
+  set(:project)  { create(:project, :repository) }
+  set(:user)   { create(:user) }
+  set(:label) { create(:label, project: project) }
+  set(:label2) { create(:label, project: project) }
+  let(:resource_parent) { project }
+
+  context 'when resource is issue' do
+    set(:resource) { create(:issue, project: project) }
+
+    it_behaves_like 'label note created from events'
+  end
+
+  context 'when resource is merge request' do
+    set(:resource) { create(:merge_request, source_project: project, target_project: project) }
+
+    it_behaves_like 'label note created from events'
+  end
+end
diff --git a/spec/models/resource_label_event_spec.rb b/spec/models/resource_label_event_spec.rb
index 4756caa1b97..da6e1b5610d 100644
--- a/spec/models/resource_label_event_spec.rb
+++ b/spec/models/resource_label_event_spec.rb
@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe ResourceLabelEvent, type: :model do
-  subject { build(:resource_label_event) }
+  subject { build(:resource_label_event, issue: issue) }
   let(:issue) { create(:issue) }
   let(:merge_request) { create(:merge_request) }
 
@@ -16,8 +16,6 @@ RSpec.describe ResourceLabelEvent, type: :model do
 
   describe 'validations' do
     it { is_expected.to be_valid }
-    it { is_expected.to validate_presence_of(:label) }
-    it { is_expected.to validate_presence_of(:user) }
 
     describe 'Issuable validation' do
       it 'is invalid if issue_id and merge_request_id are missing' do
@@ -45,4 +43,52 @@ RSpec.describe ResourceLabelEvent, type: :model do
       end
     end
   end
+
+  describe '#expire_etag_cache' do
+    def expect_expiration(issue)
+      expect_any_instance_of(Gitlab::EtagCaching::Store)
+        .to receive(:touch)
+        .with("/#{issue.project.namespace.to_param}/#{issue.project.to_param}/noteable/issue/#{issue.id}/notes")
+    end
+
+    it 'expires resource note etag cache on event save' do
+      expect_expiration(subject.issuable)
+
+      subject.save!
+    end
+
+    it 'expires resource note etag cache on event destroy' do
+      subject.save!
+
+      expect_expiration(subject.issuable)
+
+      subject.destroy!
+    end
+  end
+
+  describe '#outdated_markdown?' do
+    it 'returns true if label is missing and reference is not empty' do
+      subject.attributes = { reference: 'ref', label_id: nil }
+
+      expect(subject.outdated_markdown?).to be true
+    end
+
+    it 'returns true if reference is not set yet' do
+      subject.attributes = { reference: nil }
+
+      expect(subject.outdated_markdown?).to be true
+    end
+
+    it 'returns true markdown is outdated' do
+      subject.attributes = { cached_markdown_version: 0 }
+
+      expect(subject.outdated_markdown?).to be true
+    end
+
+    it 'returns false if label and reference are set' do
+      subject.attributes = { reference: 'whatever', cached_markdown_version: CacheMarkdownField::CACHE_COMMONMARK_VERSION  }
+
+      expect(subject.outdated_markdown?).to be false
+    end
+  end
 end