diff options
author | Stan Hu <stanhu@gmail.com> | 2017-11-02 15:32:22 -0700 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2017-11-02 15:35:12 -0700 |
commit | 0b18023c89864b7e38e4dc43cff9f8ad4017c044 (patch) | |
tree | a8ead1328cf7c3ef6226612b4fce0e5b707b8266 /spec/models | |
parent | 713052c7255c9c4fc33b74ca5d788644a30018ca (diff) | |
download | gitlab-ce-0b18023c89864b7e38e4dc43cff9f8ad4017c044.tar.gz |
Avoid regenerating the ref path for the environmentsh-fix-environment-slug-generation
Closes #39752
Diffstat (limited to 'spec/models')
-rw-r--r-- | spec/models/environment_spec.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/spec/models/environment_spec.rb b/spec/models/environment_spec.rb index e1be23541e8..f75de0a0d88 100644 --- a/spec/models/environment_spec.rb +++ b/spec/models/environment_spec.rb @@ -547,6 +547,15 @@ describe Environment do expect(environment.slug).to eq(original_slug) end + + it "regenerates the slug if nil" do + environment = build(:environment, slug: nil) + + new_slug = environment.slug + + expect(new_slug).not_to be_nil + expect(environment.slug).to eq(new_slug) + end end describe '#generate_slug' do @@ -583,6 +592,12 @@ describe Environment do it 'returns a path that uses the slug and does not have spaces' do expect(environment.ref_path).to start_with('refs/environments/staging-review-1-') end + + it "doesn't change when the slug is nil initially" do + environment.slug = nil + + expect(environment.ref_path).to eq(environment.ref_path) + end end describe '#external_url_for' do |