summaryrefslogtreecommitdiff
path: root/spec/models/commit_spec.rb
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2015-10-06 16:35:51 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2015-10-06 17:26:32 +0200
commitb7abba0ca0a4629a854eee0488f94f160452e2f6 (patch)
tree6979d294a5d0d50e9400518a55a86b1c3da42d96 /spec/models/commit_spec.rb
parentd15eec64604d68093d8f01711c1847ee240eb0d2 (diff)
downloadgitlab-ce-b7abba0ca0a4629a854eee0488f94f160452e2f6.tar.gz
Revamp trending projects query
This changes the query to use a COUNT nested in an INNER JOIN, instead of a COUNT plus a GROUP BY. There are two reasons for this: 1. Using a COUNT in an INNER JOIN can be quite a bit faster. 2. The use of a GROUP BY means that method calls such as "any?" (and everything else that calls "count") operate on a Hash that counts the amount of notes on a per project basis, instead of just counting the total amount of projects. The query has been moved into Project.trending as its logic is simple enough. As a result of this testing the TrendingProjectsFinder class simply involves testing if the right methods are called, removing the need for setting up database records.
Diffstat (limited to 'spec/models/commit_spec.rb')
0 files changed, 0 insertions, 0 deletions