diff options
| author | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2015-04-23 20:50:48 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2015-04-23 20:50:48 +0000 |
| commit | c30079f3f453b8c627b35cc6a552e08ef533b3bc (patch) | |
| tree | 2192a37be627a1637fe651df008cef80928fca2d /spec/models/commit_spec.rb | |
| parent | 05f0bbff0eca363e8ac7a7e7d21d71cd2ee3f61b (diff) | |
| parent | e01480a3afe24fc678ff401fc4b060ab05036bc7 (diff) | |
| download | gitlab-ce-c30079f3f453b8c627b35cc6a552e08ef533b3bc.tar.gz | |
Merge branch 'rs-mentionable-examples-refactor' into 'master'
Update mentionable shared examples to be (a bit) more understandable
These shared examples were super confusing, and honestly still kind of are, but they should be a bit better now.
I encountered a bunch of headaches in these examples while refactoring ReferenceExtractor, so that's how I ended up changing it.
See merge request !1780
Diffstat (limited to 'spec/models/commit_spec.rb')
| -rw-r--r-- | spec/models/commit_spec.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/spec/models/commit_spec.rb b/spec/models/commit_spec.rb index 11cc7762ce4..506bc3339b6 100644 --- a/spec/models/commit_spec.rb +++ b/spec/models/commit_spec.rb @@ -69,8 +69,9 @@ eos end it_behaves_like 'a mentionable' do - let(:subject) { commit } - let(:mauthor) { create :user, email: commit.author_email } + subject { commit } + + let(:author) { create(:user, email: commit.author_email) } let(:backref_text) { "commit #{subject.id}" } let(:set_mentionable_text) { ->(txt){ subject.stub(safe_message: txt) } } |