summaryrefslogtreecommitdiff
path: root/spec/lib
diff options
context:
space:
mode:
authorReuben Pereira <rpereira@gitlab.com>2019-07-12 07:04:44 +0000
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2019-07-12 07:04:44 +0000
commit28c76fb551aa8087786dc34cdda0f07ad468c332 (patch)
tree18a26294158ff09b5a204357d642a7b664f55715 /spec/lib
parent53c9885d1e25a73ab74f7efab720ca36a1c605ef (diff)
downloadgitlab-ce-28c76fb551aa8087786dc34cdda0f07ad468c332.tar.gz
Don't use bang method when there is no safe method
https://github.com/rubocop-hq/ruby-style-guide#dangerous-method-bang
Diffstat (limited to 'spec/lib')
-rw-r--r--spec/lib/gitlab/url_blocker_spec.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/lib/gitlab/url_blocker_spec.rb b/spec/lib/gitlab/url_blocker_spec.rb
index 253366e0789..f8b0cbfb6f6 100644
--- a/spec/lib/gitlab/url_blocker_spec.rb
+++ b/spec/lib/gitlab/url_blocker_spec.rb
@@ -353,7 +353,7 @@ describe Gitlab::UrlBlocker do
end
end
- describe '#validate_hostname!' do
+ describe '#validate_hostname' do
let(:ip_addresses) do
[
'2001:db8:1f70::999:de8:7648:6e8',
@@ -378,7 +378,7 @@ describe Gitlab::UrlBlocker do
it 'does not raise error for valid Ip addresses' do
ip_addresses.each do |ip|
- expect { described_class.send(:validate_hostname!, ip) }.not_to raise_error
+ expect { described_class.send(:validate_hostname, ip) }.not_to raise_error
end
end
end