Add schema validation spec

Validate the schema of the dashboard that is loaded by
Gitlab::MetricsDashboard::Service.

1 files changed, 3 insertions, 2 deletions

diff --git a/spec/lib/gitlab/metrics_dashboard/service_spec.rb b/spec/lib/gitlab/metrics_dashboard/service_spec.rb
index f9574889314..127fc28bcd6 100644
--- a/spec/lib/gitlab/metrics_dashboard/service_spec.rb
+++ b/spec/lib/gitlab/metrics_dashboard/service_spec.rb
@@ -6,14 +6,15 @@ describe Gitlab::MetricsDashboard::Service, :use_clean_rails_memory_store_cachin
   let(:project) { build(:project) }
 
   describe 'get_dashboard' do
+    let(:dashboard_schema) { JSON.parse(fixture_file('lib/gitlab/metrics_dashboard/schemas/dashboard.json')) }
+
     it 'returns a json representation of the environment dashboard' do
       result = described_class.new(project).get_dashboard
 
       expect(result.keys).to contain_exactly(:dashboard, :status)
       expect(result[:status]).to eq(:success)
 
-      expect(result[:dashboard]).to include('dashboard', 'order', 'panel_groups')
-      expect(result[:dashboard]['panel_groups']).to all( include('group', 'priority', 'panels') )
+      expect(JSON::Validator.fully_validate(dashboard_schema, result[:dashboard])).to be_empty
     end
 
     it 'caches the dashboard for subsequent calls' do