diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-08-17 19:25:56 +0200 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2017-08-17 19:25:56 +0200 |
commit | 9c22974cd14f41ed156ced0a6742dbae7412b0db (patch) | |
tree | 0fffe3714559e8574b4ac4d3b99d1253e1a879d5 /spec/javascripts/notes | |
parent | 09338e397c95b51a7c515524d7f3eb5f4eed2fb4 (diff) | |
download | gitlab-ce-9c22974cd14f41ed156ced0a6742dbae7412b0db.tar.gz |
Rename a few attribute suffixes from `_url` to `_path`
Diffstat (limited to 'spec/javascripts/notes')
4 files changed, 16 insertions, 16 deletions
diff --git a/spec/javascripts/notes/components/issue_comment_form_spec.js b/spec/javascripts/notes/components/issue_comment_form_spec.js index 5ec4c7ebd0a..cca5ec887a3 100644 --- a/spec/javascripts/notes/components/issue_comment_form_spec.js +++ b/spec/javascripts/notes/components/issue_comment_form_spec.js @@ -46,13 +46,13 @@ describe('issue_comment_form component', () => { }); it('should link to markdown docs', () => { - const { markdownDocs } = notesDataMock; - expect(vm.$el.querySelector(`a[href="${markdownDocs}"]`).textContent.trim()).toEqual('Markdown'); + const { markdownDocsPath } = notesDataMock; + expect(vm.$el.querySelector(`a[href="${markdownDocsPath}"]`).textContent.trim()).toEqual('Markdown'); }); it('should link to quick actions docs', () => { - const { quickActionsDocs } = notesDataMock; - expect(vm.$el.querySelector(`a[href="${quickActionsDocs}"]`).textContent.trim()).toEqual('quick actions'); + const { quickActionsDocsPath } = notesDataMock; + expect(vm.$el.querySelector(`a[href="${quickActionsDocsPath}"]`).textContent.trim()).toEqual('quick actions'); }); describe('edit mode', () => { diff --git a/spec/javascripts/notes/components/issue_note_app_spec.js b/spec/javascripts/notes/components/issue_note_app_spec.js index 1a782a32c43..22e91c4c40f 100644 --- a/spec/javascripts/notes/components/issue_note_app_spec.js +++ b/spec/javascripts/notes/components/issue_note_app_spec.js @@ -204,13 +204,13 @@ describe('issue_note_app', () => { }); it('should render markdown docs url', () => { - const { markdownDocs } = mockData.notesDataMock; - expect(vm.$el.querySelector(`a[href="${markdownDocs}"]`).textContent.trim()).toEqual('Markdown'); + const { markdownDocsPath } = mockData.notesDataMock; + expect(vm.$el.querySelector(`a[href="${markdownDocsPath}"]`).textContent.trim()).toEqual('Markdown'); }); it('should render quick action docs url', () => { - const { quickActionsDocs } = mockData.notesDataMock; - expect(vm.$el.querySelector(`a[href="${quickActionsDocs}"]`).textContent.trim()).toEqual('quick actions'); + const { quickActionsDocsPath } = mockData.notesDataMock; + expect(vm.$el.querySelector(`a[href="${quickActionsDocsPath}"]`).textContent.trim()).toEqual('quick actions'); }); }); @@ -227,11 +227,11 @@ describe('issue_note_app', () => { it('should render markdown docs url', (done) => { setTimeout(() => { vm.$el.querySelector('.js-note-edit').click(); - const { markdownDocs } = mockData.notesDataMock; + const { markdownDocsPath } = mockData.notesDataMock; Vue.nextTick(() => { expect( - vm.$el.querySelector(`.edit-note a[href="${markdownDocs}"]`).textContent.trim(), + vm.$el.querySelector(`.edit-note a[href="${markdownDocsPath}"]`).textContent.trim(), ).toEqual('Markdown is supported'); done(); }); @@ -241,11 +241,11 @@ describe('issue_note_app', () => { it('should not render quick actions docs url', (done) => { setTimeout(() => { vm.$el.querySelector('.js-note-edit').click(); - const { quickActionsDocs } = mockData.notesDataMock; + const { quickActionsDocsPath } = mockData.notesDataMock; Vue.nextTick(() => { expect( - vm.$el.querySelector(`.edit-note a[href="${quickActionsDocs}"]`), + vm.$el.querySelector(`.edit-note a[href="${quickActionsDocsPath}"]`), ).toEqual(null); done(); }); diff --git a/spec/javascripts/notes/components/issue_note_form_spec.js b/spec/javascripts/notes/components/issue_note_form_spec.js index 702e22bb6dc..a90dbcb72b5 100644 --- a/spec/javascripts/notes/components/issue_note_form_spec.js +++ b/spec/javascripts/notes/components/issue_note_form_spec.js @@ -53,8 +53,8 @@ describe('issue_note_form component', () => { }); it('should link to markdown docs', () => { - const { markdownDocs } = notesDataMock; - expect(vm.$el.querySelector(`a[href="${markdownDocs}"]`).textContent.trim()).toEqual('Markdown'); + const { markdownDocsPath } = notesDataMock; + expect(vm.$el.querySelector(`a[href="${markdownDocsPath}"]`).textContent.trim()).toEqual('Markdown'); }); describe('keyboard events', () => { diff --git a/spec/javascripts/notes/mock_data.js b/spec/javascripts/notes/mock_data.js index 54048cc68f2..89ba3a002b7 100644 --- a/spec/javascripts/notes/mock_data.js +++ b/spec/javascripts/notes/mock_data.js @@ -2,10 +2,10 @@ export const notesDataMock = { discussionsPath: '/gitlab-org/gitlab-ce/issues/26/discussions.json', lastFetchedAt: '1501862675', - markdownDocs: '/help/user/markdown', + markdownDocsPath: '/help/user/markdown', newSessionPath: '/users/sign_in?redirect_to_referer=yes', notesPath: '/gitlab-org/gitlab-ce/noteable/issue/98/notes', - quickActionsDocs: '/help/user/project/quick_actions', + quickActionsDocsPath: '/help/user/project/quick_actions', registerPath: '/users/sign_in?redirect_to_referer=yes#register-pane', }; |