diff options
author | Mike Greiling <mike@pixelcog.com> | 2019-01-24 21:54:04 +0000 |
---|---|---|
committer | Mike Greiling <mike@pixelcog.com> | 2019-01-24 21:54:04 +0000 |
commit | d6239b88b25e64aefaee0b272f082f24c5a97881 (patch) | |
tree | c13d6c699e8eafb157bc3d40772abb32383278e2 /spec/features | |
parent | 99e363debddbc75e1bc401dcecd41ea748b001e0 (diff) | |
parent | a8dcc181da5fdd564360cd6291522e89488def3e (diff) | |
download | gitlab-ce-d6239b88b25e64aefaee0b272f082f24c5a97881.tar.gz |
Merge branch '53950-commit-comments-displayed-on-a-merge-request' into 'master'56221-spec-features-projects-clusters-gcp_spec-rb-appears-to-be-making-real-google-api-requests
Resolve "Commit comments displayed on a merge request that contains that commit no longer specify which commit they come from"
Closes #53950
See merge request gitlab-org/gitlab-ce!24427
Diffstat (limited to 'spec/features')
-rw-r--r-- | spec/features/merge_request/user_sees_discussions_spec.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/spec/features/merge_request/user_sees_discussions_spec.rb b/spec/features/merge_request/user_sees_discussions_spec.rb index 4ab9a87ad4b..57be1d06708 100644 --- a/spec/features/merge_request/user_sees_discussions_spec.rb +++ b/spec/features/merge_request/user_sees_discussions_spec.rb @@ -88,5 +88,17 @@ describe 'Merge request > User sees discussions', :js do expect(page).to have_content "started a discussion on commit #{note.commit_id[0...7]}" end end + + context 'a commit non-diff discussion' do + let(:note) { create(:discussion_note_on_commit, project: project) } + + it 'displays correct header' do + page.within(find("#note_#{note.id}", match: :first)) do + refresh # Trigger a refresh of notes. + wait_for_requests + expect(page).to have_content "commented on commit #{note.commit_id[0...7]}" + end + end + end end end |