diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-06-17 15:08:41 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-06-17 15:08:41 +0000 |
| commit | 2d622d44fd4e08536d6a79cf480da8e751dae1bc (patch) | |
| tree | 94fad186a6e7a981513ddad214d44cb20054ec31 /spec/controllers/commit_controller_spec.rb | |
| parent | a2ce5188fb41794eacfb6ed823de1d4f8e2a1b17 (diff) | |
| parent | aef6214c42c6b6abc7f84f9c92f5f9b836157c9a (diff) | |
| download | gitlab-ce-2d622d44fd4e08536d6a79cf480da8e751dae1bc.tar.gz | |
Merge branch 'validate-only-except-regexp' into 'master'
Validate only and except regexp
## What does this MR do?
Adds a better validation for only and except which can contain regexps.
## Why was this MR needed?
Currently the RegexpError can be raised when processing next stage which leads to 500 in different places of code base.
This adds early check that regexps used in only and except are valid.
cc @grzesiek
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4736
Diffstat (limited to 'spec/controllers/commit_controller_spec.rb')
0 files changed, 0 insertions, 0 deletions