diff options
author | Sean McGivern <sean@gitlab.com> | 2017-12-11 16:34:51 +0000 |
---|---|---|
committer | Sean McGivern <sean@gitlab.com> | 2017-12-11 16:34:51 +0000 |
commit | 1ab33b15d1f1cc6ce69514e545da1348fd750771 (patch) | |
tree | af4dab71355a5199facc7937aeb03f964e2f6d0c /rubocop/rubocop.rb | |
parent | 8ff63039f1ee5f6e31a8b910e323977e7de3c634 (diff) | |
download | gitlab-ce-1ab33b15d1f1cc6ce69514e545da1348fd750771.tar.gz |
Add cop for use of remove_columnadd-remove-column-cop
remove_column should only be used in the up (or change) step of a migration if
it's a post-deployment migration. Otherwise there will be downtime due to the
ActiveRecord column cache, which we can avoid by using the IgnorableColumn
concern in combination with a post-deployment migration.
Diffstat (limited to 'rubocop/rubocop.rb')
-rw-r--r-- | rubocop/rubocop.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/rubocop/rubocop.rb b/rubocop/rubocop.rb index 7621ea50da9..eb52be3d731 100644 --- a/rubocop/rubocop.rb +++ b/rubocop/rubocop.rb @@ -14,6 +14,7 @@ require_relative 'cop/migration/add_index' require_relative 'cop/migration/add_timestamps' require_relative 'cop/migration/datetime' require_relative 'cop/migration/hash_index' +require_relative 'cop/migration/remove_column' require_relative 'cop/migration/remove_concurrent_index' require_relative 'cop/migration/remove_index' require_relative 'cop/migration/reversible_add_column_with_default' |