diff options
author | Walmyr Lima <walmyr@gitlab.com> | 2019-04-29 13:34:01 +0200 |
---|---|---|
committer | Walmyr Lima <walmyr@gitlab.com> | 2019-04-29 13:39:59 +0200 |
commit | d80080b5cb6721e8d08d9cb8702c59730215467a (patch) | |
tree | 9a67f06d8f9647093df93c51a47f8d462578132f /qa | |
parent | 33d5ec5b56b680f299ddd2b2f5bd666141eafefc (diff) | |
download | gitlab-ce-d80080b5cb6721e8d08d9cb8702c59730215467a.tar.gz |
Move test method to the bottom
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.
This improves code readability.
Diffstat (limited to 'qa')
-rw-r--r-- | qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb b/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb index 309ae6cd986..e689ba4c69c 100644 --- a/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb +++ b/qa/qa/specs/features/browser_ui/3_create/wiki/create_edit_clone_push_wiki_spec.rb @@ -3,11 +3,6 @@ module QA context 'Create' do describe 'Wiki management' do - def validate_content(content) - expect(page).to have_content('Wiki was successfully updated') - expect(page).to have_content(/#{content}/) - end - it 'user creates, edits, clones, and pushes to the wiki' do Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.perform(&:sign_in_using_credentials) @@ -38,6 +33,11 @@ module QA expect(page).to have_content('My Third Wiki Content') end + + def validate_content(content) + expect(page).to have_content('Wiki was successfully updated') + expect(page).to have_content(/#{content}/) + end end end end |