diff options
| author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-09-27 11:45:16 +0200 |
|---|---|---|
| committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2017-09-27 11:45:16 +0200 |
| commit | 26e73c2e8fa3d6cdd85ba82628981d3334445aeb (patch) | |
| tree | 67b1a286e243253961c84c1a6e9d113869820804 /lib | |
| parent | 057a8b709346a89e2ccdfe6e9b352ce5f93e71c7 (diff) | |
| download | gitlab-ce-26e73c2e8fa3d6cdd85ba82628981d3334445aeb.tar.gz | |
Add some minor improvements to pipeline creation chainbackstage/gb/refactor-pipeline-create-service
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/ci/pipeline/chain/sequence.rb | 5 | ||||
| -rw-r--r-- | lib/gitlab/ci/pipeline/chain/validate/repository.rb | 2 |
2 files changed, 2 insertions, 5 deletions
diff --git a/lib/gitlab/ci/pipeline/chain/sequence.rb b/lib/gitlab/ci/pipeline/chain/sequence.rb index c80d583939c..015f2988327 100644 --- a/lib/gitlab/ci/pipeline/chain/sequence.rb +++ b/lib/gitlab/ci/pipeline/chain/sequence.rb @@ -18,7 +18,7 @@ module Gitlab break if step.break? - @completed << true + @completed << step end @pipeline.tap do @@ -27,8 +27,7 @@ module Gitlab end def complete? - @completed.size == @sequence.size && - @completed.all? + @completed.size == @sequence.size end end end diff --git a/lib/gitlab/ci/pipeline/chain/validate/repository.rb b/lib/gitlab/ci/pipeline/chain/validate/repository.rb index 9d328c9cedb..70a4cfdbdea 100644 --- a/lib/gitlab/ci/pipeline/chain/validate/repository.rb +++ b/lib/gitlab/ci/pipeline/chain/validate/repository.rb @@ -14,8 +14,6 @@ module Gitlab ## TODO, we check commit in the service, that is why # there is no repository access here. # - # Should we validate repository before building a pipeline? - # unless pipeline.sha return error('Commit not found') end |