diff options
| author | Sean McGivern <sean@gitlab.com> | 2016-05-10 18:03:55 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2016-05-10 18:13:52 +0100 |
| commit | 97424ea544d0954e582a356586270e983d3bbb7a (patch) | |
| tree | 9d56780368e9823002f0d15ddc29e8db190090bf /lib | |
| parent | 98d8e3fe9ff4d120469378490c41381ae751597e (diff) | |
| download | gitlab-ce-97424ea544d0954e582a356586270e983d3bbb7a.tar.gz | |
Restrict starred projects to viewable ones
`User#starred_projects` doesn't perform any visibility checks. This has
a couple of problems:
1. It assumes a user can always view all of their starred projects in
perpetuity (project not changed to private, access revoked, etc.).
2. It assumes that we'll only ever allow a user to star a project they
can view. This is currently the case, but bugs happen.
Add `User#viewable_starred_projects` to filter the starred projects by
those the user either has explicit access to, or are public or
internal. Then use that in all places where we list the user's starred
projects.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/api/projects.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/api/projects.rb b/lib/api/projects.rb index cc2c7a0c503..9b595772675 100644 --- a/lib/api/projects.rb +++ b/lib/api/projects.rb @@ -44,7 +44,7 @@ module API # Example Request: # GET /projects/starred get '/starred' do - @projects = current_user.starred_projects + @projects = current_user.viewable_starred_projects @projects = filter_projects(@projects) @projects = paginate @projects present @projects, with: Entities::Project |