summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-11-15 22:49:48 -0800
committerStan Hu <stanhu@gmail.com>2018-11-16 00:23:36 -0800
commit198f2a0b6149a2e7c069ad3aaad6ced9f5bb3ea1 (patch)
treebf41d60dccb32bbb689bb853655535a691963981 /lib
parent6494467a191f119af31ce3e8d3f32885c1244bdc (diff)
downloadgitlab-ce-198f2a0b6149a2e7c069ad3aaad6ced9f5bb3ea1.tar.gz
Use Nokogiri as the ActiveSupport XML backendsh-use-nokogiri-xml-backend
This significantly improves performance and reduces memory consumption when parsing XML files. On a test with 124 JUnit files from a CE build, there was about a 4x reduction in processing time. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54068
Diffstat (limited to 'lib')
-rw-r--r--lib/gitlab/ci/parsers/test/junit.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/gitlab/ci/parsers/test/junit.rb b/lib/gitlab/ci/parsers/test/junit.rb
index ed5a79d9b9b..2791730fd26 100644
--- a/lib/gitlab/ci/parsers/test/junit.rb
+++ b/lib/gitlab/ci/parsers/test/junit.rb
@@ -14,7 +14,7 @@ module Gitlab
test_case = create_test_case(test_case)
test_suite.add_test_case(test_case)
end
- rescue REXML::ParseException
+ rescue Nokogiri::XML::SyntaxError
raise JunitParserError, "XML parsing failed"
rescue
raise JunitParserError, "JUnit parsing failed"