diff options
author | Kamil Trzciński <ayufan@ayufan.eu> | 2016-12-15 11:12:29 +0000 |
---|---|---|
committer | Kamil Trzciński <ayufan@ayufan.eu> | 2016-12-15 11:12:29 +0000 |
commit | 677e7e837e3fb41deb46cb77de8b9395d031c07c (patch) | |
tree | 5a8960259b97eb23d852a7fccae7505ffa0154e7 /lib/mattermost | |
parent | 01ffcceb81f1a556cdce15ec89c15be12dba9732 (diff) | |
parent | 215b9f733c097bc1eac7ca3b37302c3594904a28 (diff) | |
download | gitlab-ce-677e7e837e3fb41deb46cb77de8b9395d031c07c.tar.gz |
Merge branch 'seed-runner-token' into 'master'
Allow users to seed the initial runner registration token using an environment variable
## What does this MR do?
Allow users to seed the initial runner registration token using an environment variable
## Are there points in the code the reviewer needs to double check?
- Naming, do we want to make sure we are clear it's the 'registration' token. Like GITLAB_RUNNER_REGISTRATION_TOKEN vs what I have now, GITLAB_RUNNER_TOKEN
- Not sure we've tested a seed fixture before, I just made up a directory structure for the test
## Why was this MR needed?
At the moment I want to use this in our idea to production demo: https://gitlab.com/gitlab-org/gitlab-ce/issues/22190
This is useful for when runner is bundled with gitlab, like in a kubernetes stack, and we want the runner to be able to register with gitlab as soon as they both come up.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !6642
Diffstat (limited to 'lib/mattermost')
0 files changed, 0 insertions, 0 deletions