diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2017-08-01 12:55:57 -0400 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2017-08-01 12:55:57 -0400 |
| commit | 939e9bdde144849cbc11091985bca0a27f6e75ac (patch) | |
| tree | d6b1075fddd5ec546a1bd199a67b5391f6a64342 /lib/gitlab.rb | |
| parent | 4c77c30fbfb3734fd893f7cfe540fa595ea6539c (diff) | |
| download | gitlab-ce-939e9bdde144849cbc11091985bca0a27f6e75ac.tar.gz | |
Make the 'issuables list meta-data' shared example less dangerousrs-issuables-list-metadata-shared-examples
This shared example would take an object's database ID and create a
number of objects based on it. If for some reason the ID were a high
number, like 20, this would create `20 + 21 + 22` objects.
Not only was this dangerous from a performance perspective, it was
entirely unnecessary, as the behavior it was testing is already
well-tested in the unit test for the underlying object. For a controller
test, which is what's including this shared example, all we need to do
is verify that the assigned object contains the correct `id => object`
Hash, which is what we now test for.
Diffstat (limited to 'lib/gitlab.rb')
0 files changed, 0 insertions, 0 deletions
