summaryrefslogtreecommitdiff
path: root/lib/banzai
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2016-05-26 13:38:28 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2016-06-01 16:22:35 +0200
commit580d250166d97bd5c2b0526be737d02806e577c2 (patch)
tree83f4266e3a09621eea233051eb7b08544791f183 /lib/banzai
parent35e977d69b622e5a82be58c632ddc427d771cc09 (diff)
downloadgitlab-ce-580d250166d97bd5c2b0526be737d02806e577c2.tar.gz
Refactor Participable
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
Diffstat (limited to 'lib/banzai')
0 files changed, 0 insertions, 0 deletions