diff options
| author | Sean McGivern <sean@gitlab.com> | 2019-06-06 17:49:08 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2019-06-07 10:05:57 +0100 |
| commit | 1617aa27562c6c92c981cadf13f0fb999558e1cc (patch) | |
| tree | fa2c5d328fb4d2f7f75dd174734b7caa341fa1a0 /lib/banzai | |
| parent | a18b7e7e2b5d729a06bf109a5a0a7e42e19ecab4 (diff) | |
| download | gitlab-ce-1617aa27562c6c92c981cadf13f0fb999558e1cc.tar.gz | |
Allow emoji in label and milestone referencesallow-emoji-in-references
If we put the emoji filter before the reference filters, each emoji will
have a wrapper element that prevents the reference filter from detecting
the presence of the emoji.
As the emoji filter now runs after the reference filters, references
must contain a literal emoji, not the GitLab Flavored Markdown
versions (:100`, for example).
A weird side-effect is that if you have a label with the 100 emoji, and
a label named :100:, then trying to reference the latter will work (link
to the correct label), but will render with the 100 emoji. I'm
comfortable with that edge case, I think.
Diffstat (limited to 'lib/banzai')
| -rw-r--r-- | lib/banzai/pipeline/gfm_pipeline.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/banzai/pipeline/gfm_pipeline.rb b/lib/banzai/pipeline/gfm_pipeline.rb index 30cafd11834..d67f461be57 100644 --- a/lib/banzai/pipeline/gfm_pipeline.rb +++ b/lib/banzai/pipeline/gfm_pipeline.rb @@ -25,7 +25,6 @@ module Banzai Filter::VideoLinkFilter, Filter::ImageLazyLoadFilter, Filter::ImageLinkFilter, - Filter::EmojiFilter, Filter::TableOfContentsFilter, Filter::AutolinkFilter, Filter::ExternalLinkFilter, @@ -34,6 +33,7 @@ module Banzai *reference_filters, + Filter::EmojiFilter, Filter::TaskListFilter, Filter::InlineDiffFilter, |