diff options
author | Valeriy Sizov <vsv2711@gmail.com> | 2012-10-25 13:38:55 +0300 |
---|---|---|
committer | Valeriy Sizov <vsv2711@gmail.com> | 2012-10-25 13:38:55 +0300 |
commit | 4281de3640dabe6b913b6b0dc3273d52b6906021 (patch) | |
tree | a1f63f66c30abeac54bc0515843b0d08685af48f /lib/api | |
parent | 56bf829c753662a880805b278cae87d9cd1aa3ac (diff) | |
download | gitlab-ce-4281de3640dabe6b913b6b0dc3273d52b6906021.tar.gz |
API: review 2
Diffstat (limited to 'lib/api')
-rw-r--r-- | lib/api/entities.rb | 3 | ||||
-rw-r--r-- | lib/api/merge_requests.rb | 5 |
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/api/entities.rb b/lib/api/entities.rb index 5804e943d3e..9e605a607a2 100644 --- a/lib/api/entities.rb +++ b/lib/api/entities.rb @@ -65,8 +65,7 @@ module Gitlab end class MergeRequest < Grape::Entity - expose :id, :target_branch, :source_branch, :project_id, - :title, :closed, :merged + expose :id, :target_branch, :source_branch, :project_id, :title, :closed, :merged expose :author, :assignee, using: Entities::UserBasic end diff --git a/lib/api/merge_requests.rb b/lib/api/merge_requests.rb index b2f4fe0c961..d8f2c51293a 100644 --- a/lib/api/merge_requests.rb +++ b/lib/api/merge_requests.rb @@ -50,12 +50,12 @@ module Gitlab # POST /projects/:id/merge_requests # post ":id/merge_requests" do + authorize! :write_merge_request, user_project + attrs = attributes_for_keys [:source_branch, :target_branch, :assignee_id, :title] merge_request = user_project.merge_requests.new(attrs) merge_request.author = current_user - authorize! :write_merge_request, user_project - if merge_request.save merge_request.reload_code present merge_request, with: Entities::MergeRequest @@ -105,6 +105,7 @@ module Gitlab merge_request = user_project.merge_requests.find(params[:merge_request_id]) note = merge_request.notes.new(note: params[:note], project_id: user_project.id) note.author = current_user + if note.save present note, with: Entities::Note else |