summaryrefslogtreecommitdiff
path: root/lib/api
diff options
context:
space:
mode:
authorThong Kuah <tkuah@gitlab.com>2019-06-28 08:14:09 +0000
committerThong Kuah <tkuah@gitlab.com>2019-06-28 08:14:09 +0000
commitd69f9af7cf4d208a87379a211ff63fc7f1e5fce4 (patch)
treeeb808417379c5b35b49b11a108b7b5d37087866f /lib/api
parentb0845b6293cc31f29583116ab583e77aad6a892f (diff)
parent04d2d8f9b7e8593cb0ea3d8db7b57b843387fa2b (diff)
downloadgitlab-ce-d69f9af7cf4d208a87379a211ff63fc7f1e5fce4.tar.gz
Merge branch '63212-n-1-queries-in-projects-id-boards-api' into 'master'
Remove N+1 queries in boards API See merge request gitlab-org/gitlab-ce!29634
Diffstat (limited to 'lib/api')
-rw-r--r--lib/api/boards.rb2
-rw-r--r--lib/api/boards_responses.rb2
-rw-r--r--lib/api/entities.rb2
-rw-r--r--lib/api/group_boards.rb2
4 files changed, 4 insertions, 4 deletions
diff --git a/lib/api/boards.rb b/lib/api/boards.rb
index b7c77730afb..4e31f74f18a 100644
--- a/lib/api/boards.rb
+++ b/lib/api/boards.rb
@@ -27,7 +27,7 @@ module API
end
get '/' do
authorize!(:read_board, user_project)
- present paginate(board_parent.boards), with: Entities::Board
+ present paginate(board_parent.boards.with_associations), with: Entities::Board
end
desc 'Find a project board' do
diff --git a/lib/api/boards_responses.rb b/lib/api/boards_responses.rb
index 86d9b24802f..68497a08fb8 100644
--- a/lib/api/boards_responses.rb
+++ b/lib/api/boards_responses.rb
@@ -11,7 +11,7 @@ module API
end
def board_lists
- board.lists.destroyable
+ board.destroyable_lists
end
def create_list
diff --git a/lib/api/entities.rb b/lib/api/entities.rb
index ead01dc53f7..d783591c238 100644
--- a/lib/api/entities.rb
+++ b/lib/api/entities.rb
@@ -1101,7 +1101,7 @@ module API
expose :project, using: Entities::BasicProjectDetails
expose :lists, using: Entities::List do |board|
- board.lists.destroyable
+ board.destroyable_lists
end
end
diff --git a/lib/api/group_boards.rb b/lib/api/group_boards.rb
index 9a20ee8c8b9..feb2254963e 100644
--- a/lib/api/group_boards.rb
+++ b/lib/api/group_boards.rb
@@ -37,7 +37,7 @@ module API
use :pagination
end
get '/' do
- present paginate(board_parent.boards), with: Entities::Board
+ present paginate(board_parent.boards.with_associations), with: Entities::Board
end
end