diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-08-12 15:04:08 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-08-12 15:04:08 +0000 |
| commit | 283b2c0b15bbd39136f601f595157033850dd5a8 (patch) | |
| tree | d70dde807ea3af22790b670f5666da3fb1f650bd /lib/api/notes.rb | |
| parent | b2828d4145ac01468a59b821ced29dd248526089 (diff) | |
| parent | 7cfc47432170be14f9449a77f893c4662634019d (diff) | |
| download | gitlab-ce-283b2c0b15bbd39136f601f595157033850dd5a8.tar.gz | |
Merge branch 'improve-pipeline-processing' into 'master'
Improve pipeline processing
## What does this MR do?
This works on top of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5295 trying to solve some edge cases introduced by that Merge Request. The fix switches to a state machine which is already a part of `Ci::Pipeline` and uses events with conditional transitions to switch between pipeline states.
This is approach is much more bullet proof and much easier to understand than a previous one where we were calling a `reload_status!` which manually updated `status`. Previous approach become confusing and prone to number of errors.
## Why was this MR needed?
This improves changes introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5295
## What are the relevant issue numbers?
None, yet.
## Screenshots (if relevant)
Not needed.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added (not needed since changelog for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5295 is already introduced)
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added (not needed)
- Tests
- [x] Added for this feature/bug (most of tests do cover the triggering of Pipeline)
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5782
Diffstat (limited to 'lib/api/notes.rb')
0 files changed, 0 insertions, 0 deletions
