diff options
| author | Rémy Coutable <remy@rymai.me> | 2017-09-14 10:26:12 +0200 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2017-09-14 10:29:35 +0200 |
| commit | cc66c3fda295c992f9e4e804ebc3af774a599f6a (patch) | |
| tree | 990f23967501ba4321a1e20ab336ce4b23b4ce8e /lib/api/files.rb | |
| parent | d3fb1da12011b1fcaa3e2fc5c38b6cc87f3d38ab (diff) | |
| download | gitlab-ce-cc66c3fda295c992f9e4e804ebc3af774a599f6a.tar.gz | |
Don't force the encoding of the OAuth provider in Gitlab::OAuth::AuthHash#provider37845-fix-oauth-provider-forced-encoding
Some providers freeze their name (e.g.
https://github.com/zquestz/omniauth-google-oauth2/blob/414c43ef3ffec37d473321f262e80f1e46dda89f/lib/omniauth/strategies/google_oauth2.rb#L1),
so trying to modify the string would fail with a `can't modify frozen
String` exception (see
https://gitlab.com/gitlab-org/gitlab-ce/issues/37845#note_40308148).
In this case, we can just stop trying to force the encoding of the
provider name as they should always be in utf8 by default.
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'lib/api/files.rb')
0 files changed, 0 insertions, 0 deletions