diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2018-11-09 16:34:17 +0000 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2018-11-09 16:38:59 +0000 |
| commit | 11dd9d6e1f18b75926a4ae2284dce2343d2b5230 (patch) | |
| tree | 37761d4f3da2f4a5859acfdcc4a006bd6626bf93 /lib/api/files.rb | |
| parent | 57cee17673a711ff023fd1a9766defefd0103a9f (diff) | |
| download | gitlab-ce-11dd9d6e1f18b75926a4ae2284dce2343d2b5230.tar.gz | |
Resolve possible cherry pick API race conditionrs-cherry-pick-api
Previously, we just fetched the latest commit for the given branch when
presenting the resulting commit, but because something could have been
committed to that branch between the time we cherry-picked and the time
we render the result, the wrong commit could have been presented.
Now, we fetch the commit object with the commit SHA returned by the
commit change service, which should always be the correct commit.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53773
Diffstat (limited to 'lib/api/files.rb')
0 files changed, 0 insertions, 0 deletions