Merge branch 'lazy-diffs' into 'master'

Lazy diffs

Needs https://gitlab.com/gitlab-org/gitlab_git/merge_requests/65

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/10785

-   Use Gitlab::Git::DiffCollection which limits the result set size.
    This avoids loading unnecessary data from Git/SQL into memory.
-   Remove left-over Grit timeout handling code.
-   Use Gitlab::Git::Count.lines to count lines in strings.
-   Use more iterators.

See merge request !2705

1 files changed, 5 insertions, 2 deletions

diff --git a/features/steps/project/commits/commits.rb b/features/steps/project/commits/commits.rb
index f9fd7332464..93c37bf507f 100644
--- a/features/steps/project/commits/commits.rb
+++ b/features/steps/project/commits/commits.rb
@@ -126,8 +126,11 @@ class Spinach::Features::ProjectCommits < Spinach::FeatureSteps
   end
 
   step 'I visit big commit page' do
-    stub_const('Commit::DIFF_SAFE_FILES', 20)
-    visit namespace_project_commit_path(@project.namespace, @project, sample_big_commit.id)
+    # Create a temporary scope to ensure that the stub_const is removed after user
+    RSpec::Mocks.with_temporary_scope do
+      stub_const('Gitlab::Git::DiffCollection::DEFAULT_LIMITS', { max_lines: 1, max_files: 1 })
+      visit namespace_project_commit_path(@project.namespace, @project, sample_big_commit.id)
+    end
   end
 
   step 'I see big commit warning' do