diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-07-05 15:48:03 +0000 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-07-05 15:48:03 +0000 |
| commit | 5323fe418b4ce6e9c28dac9a6b975d7ec604ec0e (patch) | |
| tree | 47e21d423135d9f1bfb91566214670a9ca9564a3 /features/profile/emails.feature | |
| parent | 670073765a29293624eee68adf778e3ae174e6c0 (diff) | |
| parent | c7b68b6e66a487b8b12556fe10dd1dde78581eca (diff) | |
| download | gitlab-ce-5323fe418b4ce6e9c28dac9a6b975d7ec604ec0e.tar.gz | |
Merge branch 'rs-avatar_url-performance' into 'master'
Dumb-down avatar presence check in `avatar_url` methods
`avatar.present?` goes through CarrierWave, and checks that the file
exists on disk and checks its filesize. Because we're hitting the disk,
this adds extra overhead to something where the worst-case scenario is
rendering a broken image.
Instead, we now just check that the _database attribute_ is present,
which is good enough for our purposes.
See https://gitlab.com/gitlab-org/gitlab-ce/issues/19273
See merge request !5093
Diffstat (limited to 'features/profile/emails.feature')
0 files changed, 0 insertions, 0 deletions