Refactor rake task for easier readability

1 files changed, 8 insertions, 12 deletions

diff --git a/ee/lib/tasks/gitlab/ldap.rake b/ee/lib/tasks/gitlab/ldap.rake
index 0e1416acf48..7ea20df1327 100644
--- a/ee/lib/tasks/gitlab/ldap.rake
+++ b/ee/lib/tasks/gitlab/ldap.rake
@@ -2,20 +2,16 @@ namespace :gitlab do
   namespace :ldap do
     desc 'GitLab | LDAP | Run a GroupSync'
     task group_sync: :gitlab_environment do
-      if Gitlab::Auth::LDAP::Config.group_sync_enabled?
-        $stdout.puts 'LDAP GroupSync is enabled.'
-        $stdout.puts 'Starting GroupSync...'
-
-        begin
-          EE::Gitlab::Auth::LDAP::Sync::Groups.execute
-          $stdout.puts 'Finished GroupSync.'
-        rescue => exception
-          warn "The GroupSync failed with the following error: #{exception}"
-        end
-
-      else
+      if !Gitlab::Auth::LDAP::Config.group_sync_enabled?
         $stdout.puts 'LDAP GroupSync is not enabled.'
+        exit 1
       end
+
+      $stdout.puts 'LDAP GroupSync is enabled.'
+      $stdout.puts 'Starting GroupSync...'
+
+      EE::Gitlab::Auth::LDAP::Sync::Groups.execute
+      $stdout.puts 'Finished GroupSync.'
     end
   end
 end