diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2017-10-04 08:46:31 +0000 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2017-10-04 08:46:31 +0000 |
commit | 88959e872e92549a9b3e6255bfe9c70ef2194b24 (patch) | |
tree | 46ec1f09c523e28f42dcff5d19e9fc8ae3302489 /doc | |
parent | 12d275adce0cf1951a9fd0f362cee5178d865af8 (diff) | |
parent | b88f70606d2fd5b0a116f08f7925143ff40214fa (diff) | |
download | gitlab-ce-88959e872e92549a9b3e6255bfe9c70ef2194b24.tar.gz |
Merge branch '3612-update-script-template-order-in-vue-files' into 'master'
Re-arrange <script> tags before <template> tags in .vue files
Closes #38743
See merge request gitlab-org/gitlab-ce!14671
Diffstat (limited to 'doc')
-rw-r--r-- | doc/development/fe_guide/style_guide_js.md | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/doc/development/fe_guide/style_guide_js.md b/doc/development/fe_guide/style_guide_js.md index c8d23609280..77ae6d2a0ea 100644 --- a/doc/development/fe_guide/style_guide_js.md +++ b/doc/development/fe_guide/style_guide_js.md @@ -470,7 +470,25 @@ On those a default key should not be provided. ``` #### Ordering -1. Order for a Vue Component: + +1. Tag order in `.vue` file + + ``` + <script> + // ... + </script> + + <template> + // ... + </template> + + // We don't use scoped styles but there are few instances of this + <style> + // ... + </style> + ``` + +1. Properties in a Vue Component: 1. `name` 1. `props` 1. `mixins` @@ -490,6 +508,7 @@ On those a default key should not be provided. 1. `beforeDestroy` 1. `destroyed` + #### Vue and Bootstrap 1. Tooltips: Do not rely on `has-tooltip` class name for Vue components |