summaryrefslogtreecommitdiff
path: root/doc
diff options
context:
space:
mode:
authorMichael Kozono <mkozono@gmail.com>2018-12-11 20:09:05 +0000
committerMichael Kozono <mkozono@gmail.com>2018-12-11 20:09:05 +0000
commitceb7631ca534c19f1782bdfe713c6b8d89ad5f93 (patch)
treecfe3cf51eeb4da66ff401a4546eeec4de9298782 /doc
parent1ee3c06f072924fbad64b2d447f4eb835b8427fd (diff)
downloadgitlab-ce-ceb7631ca534c19f1782bdfe713c6b8d89ad5f93.tar.gz
Fix links to sections that were moved
Diffstat (limited to 'doc')
-rw-r--r--doc/development/code_review.md4
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md
index 7788d155154..25ea2211b64 100644
--- a/doc/development/code_review.md
+++ b/doc/development/code_review.md
@@ -10,7 +10,7 @@ code is effective, understandable, maintainable, and secure.
## Getting your merge request reviewed, approved, and merged
You are strongly encouraged to get your code **reviewed** by a
-[reviewer](https://about.gitlab.com/handbook/engineering/#reviewer) as soon as
+[reviewer](https://about.gitlab.com/handbook/engineering/workflow/code-review/#reviewer) as soon as
there is any code to review, to get a second opinion on the chosen solution and
implementation, and an extra pair of eyes looking for bugs, logic problems, or
uncovered edge cases. The reviewer can be from a different team, but it is
@@ -24,7 +24,7 @@ If you need assistance with security scans or comments, feel free to include the
Security Team (`@gitlab-com/gl-security`) in the review.
Depending on the areas your merge request touches, it must be **approved** by one
-or more [maintainers](https://about.gitlab.com/handbook/engineering/#maintainer):
+or more [maintainers](https://about.gitlab.com/handbook/engineering/workflow/code-review/#maintainer):
For approvals, we use the approval functionality found in the merge request
widget. Reviewers can add their approval by [approving additionally](https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#adding-or-removing-an-approval).