diff options
| author | Mark Lapierre <mlapierre@gitlab.com> | 2019-08-29 16:22:58 +1000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-09-05 13:38:35 +0200 |
| commit | 53d35ce08a04448a8c612f9eed3ea8482c063c90 (patch) | |
| tree | f670f5a66bbdd4fb0a7e7fe61e5a4c1956b9200b /doc | |
| parent | 1c6aa98c37f3cb4221819044294020923c14f57d (diff) | |
| download | gitlab-ce-rc/qa-ml-approval-rules-tests-qa.tar.gz | |
CE backport of EE MR approvals E2E testrc/qa-ml-approval-rules-tests-qa
Includes API methods to add members to projects and groups
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/development/testing_guide/end_to_end/page_objects.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/development/testing_guide/end_to_end/page_objects.md b/doc/development/testing_guide/end_to_end/page_objects.md index 850ea6b60ac..8820b54fa87 100644 --- a/doc/development/testing_guide/end_to_end/page_objects.md +++ b/doc/development/testing_guide/end_to_end/page_objects.md @@ -167,6 +167,18 @@ There are two supported methods of defining elements within a view. Any existing `.qa-selector` class should be considered deprecated and we should prefer the `data-qa-selector` method of definition. +### Exceptions + +In some cases it might not be possible or worthwhile to add a selector. + +Some UI components use external libraries, including some maintained by third parties. +Even if a library is maintained by GitLab, the selector sanity test only runs +on code within the GitLab project, so it's not possible to specify the path for +the view for code in a library. + +In such rare cases it's reasonable to use CSS selectors in page object methods, +with a comment explaining why an `element` can't be added. + ## Running the test locally During development, you can run the `qa:selectors` test by running |