diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-08-26 15:23:53 +0000 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-08-26 15:23:53 +0000 |
commit | fc66e1cc94076b1b43119b1ce24afb5cd5656c80 (patch) | |
tree | 1cf92748c2cccba6a5f7e5a307ffa75ec529edd4 /doc/gitlab-basics/basic-git-commands.md | |
parent | 6c23fd389f5bd024e892876d593162e1a8995ad4 (diff) | |
parent | c1fe98e0b9dbe40d564dc5ddad23e14dd0e6e462 (diff) | |
download | gitlab-ce-fc66e1cc94076b1b43119b1ce24afb5cd5656c80.tar.gz |
Merge branch 'prevent-too-many-redirects-on-signin' into 'master'
Prevent too many redirects error when home page URL set to external_urll
Many users naively set the home page URL setting to external_url
(e.g. https://mydomain.com). When an unauthenticated user signs in, this
causes endless redirections. For example, this is occuring:
1. Unauthenticated user attempts to access https://mydomain.com/dashboard
2. Application redirects to the home page URL: https://mydomain.com
3. Repeat step 2
In step 3, ApplicationController should have redirected the user to
https://mydomain.com/users/sign_in. Disabling the redirection if home
page URL is the same as external_url prevents users from messing up.
* Closes https://github.com/gitlabhq/gitlabhq/issues/8843
* Closes #2057
See merge request !1210
Diffstat (limited to 'doc/gitlab-basics/basic-git-commands.md')
0 files changed, 0 insertions, 0 deletions