summaryrefslogtreecommitdiff
path: root/doc/development/testing.md
diff options
context:
space:
mode:
authorZ.J. van de Weg <git@zjvandeweg.nl>2016-11-17 21:56:38 +0100
committerZ.J. van de Weg <git@zjvandeweg.nl>2016-11-17 21:56:38 +0100
commit778b5a5a04c4861c84408c944fa8dc01411cbf55 (patch)
tree04027e55d3dfdfb35c521577c8f28db09a394ee6 /doc/development/testing.md
parent166ee0965bacc20e2ad1187321654499a9b0f825 (diff)
parentda57eb39cd2e5d8dd92b05d16f49681f1677f3e8 (diff)
downloadgitlab-ce-778b5a5a04c4861c84408c944fa8dc01411cbf55.tar.gz
Merge remote-tracking branch 'origin/master' into zj-slash-commands-mattermost
Diffstat (limited to 'doc/development/testing.md')
-rw-r--r--doc/development/testing.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/doc/development/testing.md b/doc/development/testing.md
index b0b26ccf57a..4dc535fb359 100644
--- a/doc/development/testing.md
+++ b/doc/development/testing.md
@@ -64,6 +64,7 @@ the command line via `bundle exec teaspoon`, or via a web browser at
methods.
- Use `context` to test branching logic.
- Don't `describe` symbols (see [Gotchas](gotchas.md#dont-describe-symbols)).
+- Don't assert against the absolute value of a sequence-generated attribute (see [Gotchas](gotchas.md#dont-assert-against-the-absolute-value-of-a-sequence-generated-attribute)).
- Don't supply the `:each` argument to hooks since it's the default.
- Prefer `not_to` to `to_not` (_this is enforced by Rubocop_).
- Try to match the ordering of tests to the ordering within the class.