diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-08-10 23:59:38 +0000 |
|---|---|---|
| committer | Fatih Acet <acetfatih@gmail.com> | 2016-08-10 23:59:38 +0000 |
| commit | 928edde2e6af7689b42453998bd2d129a352877d (patch) | |
| tree | cc135fe951df4603c81deb1a1b6c7bb78b41e2e0 /doc/development/sql.md | |
| parent | 279c61f3cbe79f37578ff4366adfc55a63cc5b5b (diff) | |
| parent | e3292f1ede67891feddfd896f16cfe42d3851558 (diff) | |
| download | gitlab-ce-928edde2e6af7689b42453998bd2d129a352877d.tar.gz | |
Merge branch 'fix-thumbs-award-loading-toggle' into 'master'
Fix awardable button mutuality loading spinners
## What does this MR do?
Removes the showing and hiding of loading spinners when an awardable's opposite button is selected.
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
Makes the UI more consistent. Reduces confusion of why another button is showing the loading spinner when it was not clicked on.
## What are the relevant issue numbers?
Closes #18380
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5745
Diffstat (limited to 'doc/development/sql.md')
0 files changed, 0 insertions, 0 deletions