diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-07-10 12:10:54 +0200 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-07-11 11:52:03 +0200 |
| commit | ab87e7bab1d5cc20c7b69644843bfcb1f3f16918 (patch) | |
| tree | 2f908718378fbe6984d65781ea76c623ace57eb6 /danger/metadata | |
| parent | dc629bb6b8146477fdbf9fcd11d10ebedc785029 (diff) | |
| download | gitlab-ce-ab87e7bab1d5cc20c7b69644843bfcb1f3f16918.tar.gz | |
Improve Danger files after first review
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'danger/metadata')
| -rw-r--r-- | danger/metadata/Dangerfile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/danger/metadata/Dangerfile b/danger/metadata/Dangerfile index 033a84d6ecd..3cfaa04e01b 100644 --- a/danger/metadata/Dangerfile +++ b/danger/metadata/Dangerfile @@ -1,7 +1,7 @@ # rubocop:disable Style/SignalException if gitlab.mr_body.size < 5 - fail "Please provide a merge request description." + fail "Please provide a proper merge request description." end if gitlab.mr_labels.empty? @@ -21,5 +21,5 @@ end has_pick_into_stable_label = gitlab.mr_labels.find { |label| label.start_with?('Pick into') } if gitlab.branch_for_base != "master" && !has_pick_into_stable_label - fail "All merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label." + warn "Most of the time, all merge requests should target `master`. Otherwise, please set the relevant `Pick into X.Y` label." end |