summaryrefslogtreecommitdiff
path: root/config/application.rb
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2018-11-15 22:49:48 -0800
committerStan Hu <stanhu@gmail.com>2018-11-16 00:23:36 -0800
commit198f2a0b6149a2e7c069ad3aaad6ced9f5bb3ea1 (patch)
treebf41d60dccb32bbb689bb853655535a691963981 /config/application.rb
parent6494467a191f119af31ce3e8d3f32885c1244bdc (diff)
downloadgitlab-ce-198f2a0b6149a2e7c069ad3aaad6ced9f5bb3ea1.tar.gz
Use Nokogiri as the ActiveSupport XML backendsh-use-nokogiri-xml-backend
This significantly improves performance and reduces memory consumption when parsing XML files. On a test with 124 JUnit files from a CE build, there was about a 4x reduction in processing time. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54068
Diffstat (limited to 'config/application.rb')
-rw-r--r--config/application.rb3
1 files changed, 3 insertions, 0 deletions
diff --git a/config/application.rb b/config/application.rb
index 1b084e91cfb..921baa5d617 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -158,6 +158,9 @@ module Gitlab
config.action_view.sanitized_allowed_protocols = %w(smb)
+ # Nokogiri is significantly faster and uses less memory than REXML
+ ActiveSupport::XmlMini.backend = 'Nokogiri'
+
# This middleware needs to precede ActiveRecord::QueryCache and other middlewares that
# connect to the database.
config.middleware.insert_after Rails::Rack::Logger, ::Gitlab::Middleware::BasicHealthCheck