diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-03-11 23:18:25 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-03-11 23:50:47 -0700 |
| commit | b35a6880b90df6bc97a806f053abeb579ebec62f (patch) | |
| tree | f8e6ec61af630ef8971c1a4ddbac76ca88b193f0 /changelogs | |
| parent | 121de6dc6f2aff66cc4068e1f34f0177ab5a9688 (diff) | |
| download | gitlab-ce-b35a6880b90df6bc97a806f053abeb579ebec62f.tar.gz | |
Fix counting of groups in admin dashboard
1. Ignore tables that use STI in reltuples count strategy.
Models that use Rails' single-type inheritance, such as `Group` and
`CiService`, need an additional WHERE clause to count the total
properly, which isn't supported by the reltuples strategy. For now,
we just omit these from the statistics sampling and rely on the other
strategies to get this data.
2. Fix tablesample count strategy not counting groups properly.
Models such as `Group` needs a WHERE clause to distinguish it from
namespaces. We now add in the WHERE clause if STI is in use.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/7435
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/sh-skip-sti-tables-reltuples.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/sh-skip-sti-tables-reltuples.yml b/changelogs/unreleased/sh-skip-sti-tables-reltuples.yml new file mode 100644 index 00000000000..5bf0ccf3e9d --- /dev/null +++ b/changelogs/unreleased/sh-skip-sti-tables-reltuples.yml @@ -0,0 +1,5 @@ +--- +title: Fix counting of groups in admin dashboard +merge_request: 26009 +author: +type: fixed |