diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-11-28 17:06:04 +0100 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-11-28 17:10:12 +0100 |
| commit | 631801674f0cc6b0ccf7ba7dc8ad621d21e62105 (patch) | |
| tree | 517f504d9530b54f4dc152bc6c7905bd0a81efc9 /changelogs | |
| parent | 52f5259ae40cfd868c6412ba10e28dc83877afbb (diff) | |
| download | gitlab-ce-631801674f0cc6b0ccf7ba7dc8ad621d21e62105.tar.gz | |
Reuse authors when rendering event Atom feedsevents-atom-feed-author-query
Previously we'd use "event.author_email" which translates to
"event.author.email". This would result in an extra query being executed
_for every event_ just to get the same author's Email address.
Instead of doing all this useless work we can just pass the User object
returned by "event.author" since:
1. This allows us to re-use the user object's Email address.
2. Authors are eager-loaded, so this doesn't cause any N+1 queries.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/events-atom-feed-author-query.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/events-atom-feed-author-query.yml b/changelogs/unreleased/events-atom-feed-author-query.yml new file mode 100644 index 00000000000..84c51f25de7 --- /dev/null +++ b/changelogs/unreleased/events-atom-feed-author-query.yml @@ -0,0 +1,5 @@ +--- +title: Reuse authors when rendering event Atom feeds +merge_request: +author: +type: performance |