summaryrefslogtreecommitdiff
path: root/changelogs
diff options
context:
space:
mode:
authorblackst0ne <blackst0ne.ru@gmail.com>2018-06-20 21:42:52 +1100
committerblackst0ne <blackst0ne.ru@gmail.com>2018-06-20 21:42:52 +1100
commit6da19415531e4c40f48df2c604efe51578cea295 (patch)
tree67d7f3015e0d8f8ec3522253a3698b656d1b4ba0 /changelogs
parenta88a9e22c5f27b458593d08ee9dce5a834c51f2a (diff)
downloadgitlab-ce-6da19415531e4c40f48df2c604efe51578cea295.tar.gz
[Rails5] Set request.format in commits_controllerblackst0ne-rails5-set-request-format-in--commits-controller
Since Rails 5.0 `request.format` is being set depending on the route extension. In commits pages we pass a ref as a URL parameter. If the ref is an extension-like, Rails converts it and sets to `request.format`. E.g. if the ref is `some_branch.atom`, Rails starts responding with `atom` format, but it should response with `html` because `.atom` is the part of ref name, not the format. This commit explicitly sets `request.format` to `:html` when needed.
Diffstat (limited to 'changelogs')
-rw-r--r--changelogs/unreleased/blackst0ne-rails5-set-request-format-in--commits-controller.yml5
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/blackst0ne-rails5-set-request-format-in--commits-controller.yml b/changelogs/unreleased/blackst0ne-rails5-set-request-format-in--commits-controller.yml
new file mode 100644
index 00000000000..3f8f8fd5d66
--- /dev/null
+++ b/changelogs/unreleased/blackst0ne-rails5-set-request-format-in--commits-controller.yml
@@ -0,0 +1,5 @@
+---
+title: "[Rails5] Set request.format in commits_controller"
+merge_request: 20023
+author: "@blackst0ne"
+type: fixed