diff options
| author | Oswaldo Ferreira <oswaldo@gitlab.com> | 2018-06-04 19:20:58 -0300 |
|---|---|---|
| committer | Oswaldo Ferreira <oswaldo@gitlab.com> | 2018-06-05 01:02:30 -0300 |
| commit | f46739191a71d881501bb3fc4740b953824a9fb3 (patch) | |
| tree | b6fca3e62fd627b0914441f135ffd1f878edb08b /changelogs | |
| parent | 9c2961947826442e780285cb551583b09cf6dae9 (diff) | |
| download | gitlab-ce-f46739191a71d881501bb3fc4740b953824a9fb3.tar.gz | |
Adjust insufficient diff hunks being persisted on NoteDiffFileosw-ignore-diff-header-when-persisting-diff-hunk
This currently causes 500's errors when loading the MR page
(Discussion) in a few scenarios.
We were not considering detailed diff headers such as
"--- a/doc/update/mysql_to_postgresql.md\n+++ b/doc/update/mysql_to_postgresql.md"
to crop the diff. In order to address it, we're now using
Gitlab::Diff::Parser, clean the diffs and builds Gitlab::Diff::Line objects
we can iterate and filter on.
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/unreleased/osw-ignore-diff-header-when-persisting-diff-hunk.yml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changelogs/unreleased/osw-ignore-diff-header-when-persisting-diff-hunk.yml b/changelogs/unreleased/osw-ignore-diff-header-when-persisting-diff-hunk.yml new file mode 100644 index 00000000000..ef66deaa0ef --- /dev/null +++ b/changelogs/unreleased/osw-ignore-diff-header-when-persisting-diff-hunk.yml @@ -0,0 +1,5 @@ +--- +title: Adjust insufficient diff hunks being persisted on NoteDiffFile +merge_request: +author: +type: fixed |