diff options
author | Douwe Maan <douwe@gitlab.com> | 2018-12-18 16:54:44 +0000 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2018-12-18 16:54:44 +0000 |
commit | 9ead13b8ebb5ae05bd1dd6c656bb0d56bb680c3a (patch) | |
tree | 7a21b6c47db862cf53292e071fba3341d8fd9362 /app | |
parent | add10e140017c06bba11564f68acc4a57eb0280d (diff) | |
parent | eecb6d2f78a483b141b00f735917fe93848a22f2 (diff) | |
download | gitlab-ce-9ead13b8ebb5ae05bd1dd6c656bb0d56bb680c3a.tar.gz |
Merge branch 'reduce-diff-with-ee-in-protected_refs_controller' into 'master'
Reduce diff with EE in ProtectedRefsController
See merge request gitlab-org/gitlab-ce!23885
Diffstat (limited to 'app')
-rw-r--r-- | app/controllers/projects/protected_branches_controller.rb | 4 | ||||
-rw-r--r-- | app/controllers/projects/protected_refs_controller.rb | 4 | ||||
-rw-r--r-- | app/controllers/projects/protected_tags_controller.rb | 4 |
3 files changed, 10 insertions, 2 deletions
diff --git a/app/controllers/projects/protected_branches_controller.rb b/app/controllers/projects/protected_branches_controller.rb index a860be83e95..c5454883060 100644 --- a/app/controllers/projects/protected_branches_controller.rb +++ b/app/controllers/projects/protected_branches_controller.rb @@ -15,6 +15,10 @@ class Projects::ProtectedBranchesController < Projects::ProtectedRefsController @protected_ref = @project.protected_branches.find(params[:id]) end + def access_levels + [:merge_access_levels, :push_access_levels] + end + def protected_ref_params params.require(:protected_branch).permit(:name, merge_access_levels_attributes: access_level_attributes, diff --git a/app/controllers/projects/protected_refs_controller.rb b/app/controllers/projects/protected_refs_controller.rb index 3a3a29ddd0d..4e2a9df5576 100644 --- a/app/controllers/projects/protected_refs_controller.rb +++ b/app/controllers/projects/protected_refs_controller.rb @@ -32,7 +32,7 @@ class Projects::ProtectedRefsController < Projects::ApplicationController @protected_ref = update_service_class.new(@project, current_user, protected_ref_params).execute(@protected_ref) if @protected_ref.valid? - render json: @protected_ref, status: :ok + render json: @protected_ref, status: :ok, include: access_levels else render json: @protected_ref.errors, status: :unprocessable_entity end @@ -62,6 +62,6 @@ class Projects::ProtectedRefsController < Projects::ApplicationController end def access_level_attributes - %i(access_level id) + %i[access_level id] end end diff --git a/app/controllers/projects/protected_tags_controller.rb b/app/controllers/projects/protected_tags_controller.rb index 01cedba95ac..41191639c2b 100644 --- a/app/controllers/projects/protected_tags_controller.rb +++ b/app/controllers/projects/protected_tags_controller.rb @@ -15,6 +15,10 @@ class Projects::ProtectedTagsController < Projects::ProtectedRefsController @protected_ref = @project.protected_tags.find(params[:id]) end + def access_levels + [:create_access_levels] + end + def protected_ref_params params.require(:protected_tag).permit(:name, create_access_levels_attributes: access_level_attributes) end |