diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2017-09-01 15:20:46 +0000 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2017-09-01 15:20:46 +0000 |
commit | 2bfeadd1b372d82b27a4059b7251e9b081f54b4c (patch) | |
tree | 789e4a10e5b75d59492f077dcc2b515bcc085953 /app | |
parent | dceb2112d2ec34a947edfb2c9ec4d286fea4661a (diff) | |
parent | 465813a2c8a9218ca453b3610024f25b2d51f81d (diff) | |
download | gitlab-ce-2bfeadd1b372d82b27a4059b7251e9b081f54b4c.tar.gz |
Merge branch 'fly-out-nav-hiding-fix' into 'master'
Fixes the fly-out navigation flashing in & out
Closes #37022
See merge request !13929
Diffstat (limited to 'app')
-rw-r--r-- | app/assets/javascripts/fly_out_nav.js | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/app/assets/javascripts/fly_out_nav.js b/app/assets/javascripts/fly_out_nav.js index 81697af189b..063155a167a 100644 --- a/app/assets/javascripts/fly_out_nav.js +++ b/app/assets/javascripts/fly_out_nav.js @@ -12,6 +12,7 @@ let sidebar; export const mousePos = []; export const setSidebar = (el) => { sidebar = el; }; +export const getOpenMenu = () => currentOpenMenu; export const setOpenMenu = (menu = null) => { currentOpenMenu = menu; }; export const slope = (a, b) => (b.y - a.y) / (b.x - a.x); @@ -141,6 +142,14 @@ export const documentMouseMove = (e) => { if (mousePos.length > 6) mousePos.shift(); }; +export const subItemsMouseLeave = (relatedTarget) => { + clearTimeout(timeoutId); + + if (!relatedTarget.closest(`.${IS_OVER_CLASS}`)) { + hideMenu(currentOpenMenu); + } +}; + export default () => { sidebar = document.querySelector('.nav-sidebar'); @@ -162,10 +171,7 @@ export default () => { const subItems = el.querySelector('.sidebar-sub-level-items'); if (subItems) { - subItems.addEventListener('mouseleave', () => { - clearTimeout(timeoutId); - hideMenu(currentOpenMenu); - }); + subItems.addEventListener('mouseleave', e => subItemsMouseLeave(e.relatedTarget)); } el.addEventListener('mouseenter', e => mouseEnterTopItems(e.currentTarget)); |