Improve avatar cropping internals, based on suggestions made by @rspeicher on !2773

1 files changed, 1 insertions, 8 deletions

diff --git a/app/uploaders/avatar_uploader.rb b/app/uploaders/avatar_uploader.rb
index 60ee80cf002..c8d9ab072e8 100644
--- a/app/uploaders/avatar_uploader.rb
+++ b/app/uploaders/avatar_uploader.rb
@@ -10,15 +10,8 @@ class AvatarUploader < CarrierWave::Uploader::Base
 
   process :cropper
 
-  def is_integer? string
-    true if Integer(string) rescue false
-  end
-
   def cropper
-    is_compliant = model.kind_of?(User) && is_integer?(model.avatar_crop_size)
-    is_compliant = is_compliant && is_integer?(model.avatar_crop_x) && is_integer?(model.avatar_crop_y)
-
-    if is_compliant
+    if model.kind_of?(User) && model.valid?
       manipulate! do |img|
         img.crop "#{model.avatar_crop_size}x#{model.avatar_crop_size}+#{model.avatar_crop_x}+#{model.avatar_crop_y}"
       end