Improve after code review

1 files changed, 3 insertions, 2 deletions

diff --git a/app/services/create_deployment_service.rb b/app/services/create_deployment_service.rb
index 5e6745cdd4e..85c0bf72074 100644
--- a/app/services/create_deployment_service.rb
+++ b/app/services/create_deployment_service.rb
@@ -6,10 +6,11 @@ class CreateDeploymentService < BaseService
 
     ActiveRecord::Base.transaction do
       @deployable = deployable
+
       @environment = environment
       @environment.external_url = expanded_url if expanded_url
       @environment.state_event = action
-      @environment.save
+      @environment.save!
 
       return if @environment.stopped?
 
@@ -33,7 +34,7 @@ class CreateDeploymentService < BaseService
       sha: params[:sha],
       user: current_user,
       deployable: @deployable,
-      on_stop: options.fetch(:on_stop, nil))
+      on_stop: options[:on_stop])
   end
 
   def environment