diff options
| author | Jan Beckmann <king-jan1999@hotmail.de> | 2018-06-25 14:44:29 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-06-25 14:44:29 +0000 |
| commit | 1345968ea6bda903670959b248175a0f42a0b3a0 (patch) | |
| tree | 674856cbed9b20a8355874158e3fb744ca976a3d /app/services | |
| parent | 7da7af3a22058a6fb4e22cbf2b659e910cc92d54 (diff) | |
| download | gitlab-ce-1345968ea6bda903670959b248175a0f42a0b3a0.tar.gz | |
Resolve "WebHookService doesn't handle user info with nil passwords"
Diffstat (limited to 'app/services')
| -rw-r--r-- | app/services/web_hook_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/web_hook_service.rb b/app/services/web_hook_service.rb index 7ec52b6ce2b..8a86e47f0ea 100644 --- a/app/services/web_hook_service.rb +++ b/app/services/web_hook_service.rb @@ -82,7 +82,7 @@ class WebHookService post_url = hook.url.gsub("#{parsed_url.userinfo}@", '') basic_auth = { username: CGI.unescape(parsed_url.user), - password: CGI.unescape(parsed_url.password) + password: CGI.unescape(parsed_url.password.presence || '') } make_request(post_url, basic_auth) end |