diff options
| author | Stan Hu <stanhu@gmail.com> | 2017-08-25 16:15:43 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2017-08-25 22:00:07 -0700 |
| commit | e94a2fde0dbb1802ad3e01486c2c8f6d8a3ee4da (patch) | |
| tree | 9a6a19be034620c5a388d2285b228949ce20f3b8 /app/services/users | |
| parent | 2be34630623711fc20ef8c101b5cef688f207cc1 (diff) | |
| download | gitlab-ce-e94a2fde0dbb1802ad3e01486c2c8f6d8a3ee4da.tar.gz | |
Fire system hooks when a user is created via LDAP or OAuthsh-system-hooks-ldap-users
Closes #37073
Diffstat (limited to 'app/services/users')
| -rw-r--r-- | app/services/users/create_service.rb | 8 | ||||
| -rw-r--r-- | app/services/users/update_service.rb | 6 |
2 files changed, 9 insertions, 5 deletions
diff --git a/app/services/users/create_service.rb b/app/services/users/create_service.rb index 74abc017cea..c8a3c461d60 100644 --- a/app/services/users/create_service.rb +++ b/app/services/users/create_service.rb @@ -1,5 +1,7 @@ module Users class CreateService < BaseService + include NewUserNotifier + def initialize(current_user, params = {}) @current_user = current_user @params = params.dup @@ -10,11 +12,7 @@ module Users @reset_token = user.generate_reset_token if user.recently_sent_password_reset? - if user.save - log_info("User \"#{user.name}\" (#{user.email}) was created") - notification_service.new_user(user, @reset_token) if @reset_token - system_hook_service.execute_hooks_for(user, :create) - end + notify_new_user(user, @reset_token) if user.save user end diff --git a/app/services/users/update_service.rb b/app/services/users/update_service.rb index dfbd6016c3f..2f9855273dc 100644 --- a/app/services/users/update_service.rb +++ b/app/services/users/update_service.rb @@ -1,5 +1,7 @@ module Users class UpdateService < BaseService + include NewUserNotifier + def initialize(user, params = {}) @user = user @params = params.dup @@ -10,7 +12,11 @@ module Users assign_attributes(&block) + user_exists = @user.persisted? + if @user.save(validate: validate) + notify_new_user(@user, nil) unless user_exists + success else error(@user.errors.full_messages.uniq.join('. ')) |
