diff options
author | Douwe Maan <douwe@gitlab.com> | 2015-10-12 14:30:44 +0200 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2015-10-12 14:30:44 +0200 |
commit | 27d952b1197f2dc615c383c21eb287313d81c74c (patch) | |
tree | f726ca5f19add5386bd4f4ce0de4142fd691145c /app/services/notes | |
parent | b0164771ec693ff58504ece560371ffec11f9ca9 (diff) | |
download | gitlab-ce-27d952b1197f2dc615c383c21eb287313d81c74c.tar.gz |
Fix cross-references originating from notes
Diffstat (limited to 'app/services/notes')
-rw-r--r-- | app/services/notes/create_service.rb | 8 | ||||
-rw-r--r-- | app/services/notes/update_service.rb | 2 |
2 files changed, 2 insertions, 8 deletions
diff --git a/app/services/notes/create_service.rb b/app/services/notes/create_service.rb index 482c0444049..2001dc89c33 100644 --- a/app/services/notes/create_service.rb +++ b/app/services/notes/create_service.rb @@ -11,13 +11,7 @@ module Notes # Skip system notes, like status changes and cross-references. unless note.system event_service.leave_note(note, note.author) - - # Create a cross-reference note if this Note contains GFM that names an - # issue, merge request, or commit. - note.references.each do |mentioned| - SystemNoteService.cross_reference(mentioned, note.noteable, note.author) - end - + note.create_cross_references! execute_hooks(note) end end diff --git a/app/services/notes/update_service.rb b/app/services/notes/update_service.rb index c22a9333ef6..6c2f08e5963 100644 --- a/app/services/notes/update_service.rb +++ b/app/services/notes/update_service.rb @@ -4,7 +4,7 @@ module Notes return note unless note.editable? note.update_attributes(params.merge(updated_by: current_user)) - + note.create_new_cross_references! note.reset_events_cache note |