Unify pipeline_for(ref, nil) and pipeline_for(ref), feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14073464

1 files changed, 4 insertions, 1 deletions

diff --git a/app/models/project.rb b/app/models/project.rb
index 678fca7afd1..e97e6abfef9 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -1094,8 +1094,11 @@ class Project < ActiveRecord::Base
     !namespace.share_with_group_lock
   end
 
-  def pipeline_for(ref, sha = commit(ref).try(:sha))
+  def pipeline_for(ref, sha = nil)
+    sha ||= commit(ref).try(:sha)
+
     return unless sha
+
     pipelines.order(id: :desc).find_by(sha: sha, ref: ref)
   end